Add extensions to gradle plugin#7235
Merged
owaiskazi19 merged 9 commits intoopensearch-project:mainfrom May 3, 2023
Merged
Conversation
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
requested changes
Apr 18, 2023
buildSrc/src/main/java/org/opensearch/gradle/testclusters/ExtensionsProperties.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/TestExtensionsList.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Member
Author
|
This doesn't only affect extensions, so should I add a changelog entry? |
ryanbogan
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
reta,
saratvemulapalli,
setiah,
shwetathareja and
tlfeng
as code owners
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dblock
approved these changes
Apr 20, 2023
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
LGTM!
Looking at this code, I am wondering whether we should extract the connectivity parts of an extension into an interface? I suspect that for in-proc we will not want host/port as a communication channel. WDYT?
Member
|
@owaiskazi19 Ryan addressed the comments, could you take a look again? |
Member
Makes sense. Definitely they have to be APIs. And abstract out inner structures. We started with something very simple, its about time to build these changes. |
owaiskazi19
reviewed
Apr 25, 2023
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
approved these changes
May 3, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7235-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 84d66e091a3dc4c52f72f64b3bbd2d45580feb48
# Push it to GitHub
git push --set-upstream origin backport/backport-7235-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
5 tasks
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
* Add extension functionality to OpenSearch gradle plugin Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Modify gradle plugin to run both extensions and plugins Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fix spotless Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Change feature flag initialization Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Address PR comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Change error method and remove unnecessary feature flag setting Signed-off-by: Ryan Bogan <rbogan@amazon.com> --------- Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to run integration testing for the SDK and future extensions, the OpenSearch gradle plugin needs to be able to run both extensions and plugins at the same time. This PR adds the capability to run extensions from the gradle plugin, while leaving all existing plugin functionality untouched.
Issues Resolved
opensearch-project/opensearch-sdk-java#589
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.